Re: [HACKERS] PostgreSQL 8.0.3 and Ipv6

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Petr Jelinek <pjmodos(at)seznam(dot)cz>, Magnus Hagander <mha(at)sollentuna(dot)net>, voss(at)arnet(dot)com(dot)br, Chuck McDevitt <cmcdevitt(at)greenplum(dot)com>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] PostgreSQL 8.0.3 and Ipv6
Date: 2005-08-22 17:24:44
Message-ID: 430A0A5C.2000701@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:

>Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>
>>Try this instead if you prefer.
>>
>>
>
>I thought this was a little bit too trusting about there being a
>getaddrinfo to probe, so I tightened it up as per the attached
>applied patch.
>
>Where are we at this point on the Windows/IPv6 issue --- are there
>more fixes to come, or is it done?
>
>

Not done yet. One thing left.

The idea was that we would put dynamic testing of properly working
getaddrinfo and friends on Windows into our getaddrinfo.c. That would
be the "local tweak" you mentioned previously ;-)

In consequence of that plan, I think we would need to remove "&&
defined(HAVE_GETADDRINFO)" from your applied patch and let it fall
through to our homegrown getaddrinfo if there isn't one. On most such
platforms it would fail, consuming a few more millisecs, but with
Windows with the expected patch it could pass.

(I know it's a muddle - I can't think how we came not to do IPv6 for
Windows in 8.0, or at the very least put it on the TODO list.)

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua D. Drake 2005-08-22 17:35:20 Re: enable_constraint_exclusion GUC name
Previous Message Bruce Momjian 2005-08-22 16:42:36 Re: enable_constraint_exclusion GUC name

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-08-22 20:27:45 Re: ECPG and escape strings
Previous Message Tom Lane 2005-08-22 16:30:13 Re: [HACKERS] PostgreSQL 8.0.3 and Ipv6