| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings |
| Date: | 2024-09-15 22:07:21 |
| Message-ID: | 42f2242a-422b-4aa3-8d60-d67b229c4a52@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 2024-09-15 Su 4:36 PM, Bruce Momjian wrote:
> On Sun, Sep 15, 2024 at 04:33:49PM -0400, Andrew Dunstan wrote:
>> I understand perfectly what the warning is about.
>>
>> But the project's perlcritic policy is expressed at src/tools/perlcheck/
>> perlcriticrc. It's basically severity 5 plus some additions and one exception.
>> We shouldn't be imposing our personal perlcritic policies on the project.
>>
>> The change isn't bad in itself, but there shouldn't be any expectation that we
>> will keep to this policy, as it's not required by project policy.
>>
>> There is a huge mass of perlcritic issues in our perl code at severity 1 (over
>> 13000 by my count). If we're going to clean them up (which I would oppose) we
>> should do it in a systematic way. It's hard to see why this one is special.
> I guess it is special only because my policy is more strict so I wanted
> my new code to match. Should I revert it?
Yes I think so.
> Is the very tiny improvement
> not worth the churn in the code?
Yeah, I don't think it is.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2024-09-16 01:25:26 | pgsql: Perl scripts: revert 43ce181059d |
| Previous Message | Bruce Momjian | 2024-09-15 20:36:56 | Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings |