Re: enable/disable trigger (Re: Fwd: [HACKERS] Open items)

Alvaro Herrera wrote:
> There are a few elog() calls that should really be ereport(). Also
> this message

I've fixed to call ereport() on permission error.

>>+ elog(NOTICE, "%d trigger(s) on %s %s.",
>>+ changed,
>>+ NameStr(rel->rd_rel->relname),
>>+ enable ? "enabled" : "disabled");
>
>
> should really be two messages (Maybe even four: disabled-plural,
> disabled-singular, enabled-plural, enabled-singular)

What does "really be two messages" mean?

> There's a SQL typo here:
>
>>+ appendPQExpBuffer(query, "ALTER TABLE %s DIABLE TRIGGER %s;\n",

Fixed.

--
NAGAYASU Satoshi <nagayasus(at)nttdata(dot)co(dot)jp>