From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | Satoshi Nagayasu <nagayasus(at)nttdata(dot)co(dot)jp> |
Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: enable/disable trigger (Re: Fwd: [HACKERS] Open items) |
Date: | 2005-08-08 01:18:10 |
Message-ID: | 20050808011810.GA24704@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
On Mon, Aug 08, 2005 at 08:07:05AM +0900, Satoshi Nagayasu wrote:
> Here is new patch with pg_dump modification.
There are a few elog() calls that should really be ereport(). Also
this message
> + elog(NOTICE, "%d trigger(s) on %s %s.",
> + changed,
> + NameStr(rel->rd_rel->relname),
> + enable ? "enabled" : "disabled");
should really be two messages (Maybe even four: disabled-plural,
disabled-singular, enabled-plural, enabled-singular)
There's a SQL typo here:
> + appendPQExpBuffer(query, "ALTER TABLE %s DIABLE TRIGGER %s;\n",
--
Alvaro Herrera (<alvherre[a]alvh.no-ip.org>)
"La conclusión que podemos sacar de esos estudios es que
no podemos sacar ninguna conclusión de ellos" (Tanenbaum)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-08-08 03:36:09 | Re: Cygwin - make check broken |
Previous Message | Jason Tishler | 2005-08-08 00:51:30 | Re: Cygwin - make check broken |
From | Date | Subject | |
---|---|---|---|
Next Message | Satoshi Nagayasu | 2005-08-08 05:13:28 | Re: enable/disable trigger (Re: Fwd: [HACKERS] Open items) |
Previous Message | Satoshi Nagayasu | 2005-08-07 23:07:05 | Re: enable/disable trigger (Re: Fwd: [HACKERS] Open items) |