| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Imran Zaheer <imran(dot)zhir(at)gmail(dot)com>, Dave Page <dpage(at)pgadmin(dot)org>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Windows: openssl & gssapi dislike each other |
| Date: | 2024-06-08 22:21:24 |
| Message-ID: | 425201.1717885284@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 2024-06-08 Sa 06:22, Imran Zaheer wrote:
>> Now this can either be solved by just just undefine the macro defined
>> by wincrypt.h as done here [3]
>> Or we should rearrange our headers. Openssl header should be at the
>> bottom (after the gssapi includes).
> Let's be consistent and use the #undef from [3].
+1. Depending on header order is not great, especially when you have
to make it depend on an order that is directly contradictory to
project conventions [0].
regards, tom lane
[0] https://wiki.postgresql.org/wiki/Committing_checklist#Policies
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David E. Wheeler | 2024-06-08 22:49:38 | Shouldn't jsonpath .string() Unwrap? |
| Previous Message | Aaron Altman | 2024-06-08 22:04:44 | Re: Fix grammar oddities in comments |