| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Tristan Partin <tristan(at)neon(dot)tech>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Make documentation builds reproducible |
| Date: | 2024-01-20 22:44:00 |
| Message-ID: | 4197bc82-639f-49d7-bd10-cb341dc7b7f4@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20.01.24 17:03, Tom Lane wrote:
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>> I think there was general agreement with what this patch is doing, but I
>> guess it's too boring to actually review the patch in detail. Let's
>> say, if there are no objections, I'll go ahead and commit it.
>
> I re-read the thread and have two thoughts:
>
> * We worried about whether this change would be compatible with a
> (presently unreleased) version of docbook that contains the upstreamed
> fix. It seems unlikely that there's a problem, but maybe worth
> checking?
The code in the patch is the same code as upstream, so it would behave
the same as a new release.
> * I gather that the point here is to change some generated anchor
> tags. Would any of these tags be things people would be likely
> to have bookmarked?
No, because the problem is that the anchor names are randomly generated
in each build.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-01-20 22:57:46 | Re: PG12 change to DO UPDATE SET column references |
| Previous Message | James Coleman | 2024-01-20 21:45:07 | Re: PG12 change to DO UPDATE SET column references |