| From: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Win32 tablespace |
| Date: | 2004-08-08 00:46:57 |
| Message-ID: | 41157801.9080707@pse-consulting.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Bruce Momjian wrote:
> OK, applied. I moved the funciton into port/dirmod.c and cleaned up the
> interface for Win32.
>
> Would someone test this on Win32 in case I broke something?
Yes, something's broken, see patch.
Second, HAVE_SYMLINK must be defined somewhere (configure?).
Third, a junction is a directory, not a file, so DROP tablespace must
use rmdir, not unlink to remove the junction; see my original patch.
Regards,
Andreas
| Attachment | Content-Type | Size |
|---|---|---|
| dirmod.patch | text/x-patch | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2004-08-08 01:00:10 | Re: Make psql version aware; hide tablespace from older versions |
| Previous Message | Tom Lane | 2004-08-08 00:24:22 | Re: [PATCHES] UNICODE characters above 0x10000 |