Re: Win32 tablespace

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Win32 tablespace
Date: 2004-08-08 01:32:03
Message-ID: 200408080132.i781W3L22579@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


OK, got them all. Thanks. Patch attached.

Would someone retest on Win32?

---------------------------------------------------------------------------

Andreas Pflug wrote:
> Bruce Momjian wrote:
> > OK, applied. I moved the funciton into port/dirmod.c and cleaned up the
> > interface for Win32.
> >
> > Would someone test this on Win32 in case I broke something?
>
> Yes, something's broken, see patch.
>
> Second, HAVE_SYMLINK must be defined somewhere (configure?).
>
> Third, a junction is a directory, not a file, so DROP tablespace must
> use rmdir, not unlink to remove the junction; see my original patch.
>
> Regards,
> Andreas
>
>

>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 4.0 KB

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-08-08 01:42:40 Re: PITR on Win32 - Archive and Restore
Previous Message Greg Sabino Mullane 2004-08-08 01:00:18 Re: Make psql version aware; hide tablespace from older versions