From: | Manfred Spraul <manfred(at)colorfullife(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Libpq ssl fix |
Date: | 2004-05-28 18:17:07 |
Message-ID: | 40B78223.8080701@colorfullife.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Hi,
I'll retest the patch. I didn't have a working ssl test setup, thus I
stopped when I ran into the same errors as without my patch. Probably
printfs in initialize_SSL(), but no tests that the code beyond
initialize_SSL() actually runs - sorry.
Btw, --enable-thread-safety on Linux (RedHat Fedora Core 1) fails in
configure with
> configure: error:
> *** Thread test program failed. Your platform is not thread-safe.
> *** Check the file 'config.log'for the exact reason.
--
Manfred
Tom Lane wrote:
>Andreas Pflug <pgadmin(at)pse-consulting(dot)de> writes:
>
>
>>init_ssl_system will return 0 on success and -1 on failure, which will
>>be interpreted just the other way round in initialize_SSL.
>>Patch appended.
>>
>>
>
>Hmm, that looks backwards to me too, but this would seem to imply that
>Manfred Spraul failed to test his last patch at all. Manfred, care to
>explain why we shouldn't revert that patch in toto?
>
>2004-03-23 22:44 momjian
>
> * doc/src/sgml/libpq.sgml, src/backend/libpq/md5.c,
> src/interfaces/libpq/fe-auth.c, src/interfaces/libpq/fe-connect.c,
> src/interfaces/libpq/fe-secure.c, src/interfaces/libpq/libpq-fe.h,
> src/interfaces/libpq/libpq-int.h: Add thread locking to SSL and
> Kerberos connections.
>
> I have removed the docs mentioning that SSL and Kerberos are not
> thread-safe.
>
> Manfred Spraul
>
> regards, tom lane
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Hallgren | 2004-05-28 18:21:34 | Re: Link errors on win32 |
Previous Message | Andreas Pflug | 2004-05-28 17:42:48 | Re: Libpq ssl fix |