Re: Libpq ssl fix

From: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>, Manfred Spraul <manfred(at)colorfullife(dot)com>
Subject: Re: Libpq ssl fix
Date: 2004-05-28 17:42:48
Message-ID: 40B77A18.9060004@pse-consulting.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:

>Andreas Pflug <pgadmin(at)pse-consulting(dot)de> writes:
>
>
>>init_ssl_system will return 0 on success and -1 on failure, which will
>>be interpreted just the other way round in initialize_SSL.
>>Patch appended.
>>
>>
>
>Hmm, that looks backwards to me too, but this would seem to imply that
>Manfred Spraul failed to test his last patch at all. Manfred, care to
>explain why we shouldn't revert that patch in toto?
>
>
FYI:
I tried to compile libpq with ENABLE_THREAD_SAFETY under win32, and
quickly stopped it because the implementation has pthread stuff buried
deep inside the sources. No pthread under win32... This needs quite some
portability work.

Regards,
Andreas

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Manfred Spraul 2004-05-28 18:17:07 Re: Libpq ssl fix
Previous Message Andrew Dunstan 2004-05-28 17:28:22 Re: mingw configure failure detection