| From: | Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | PG Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Bug in CVS pg_dump against 7.0.x |
| Date: | 2004-05-17 04:26:13 |
| Message-ID: | 40A83EE5.5050707@familyhealth.com.au |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
> Duh, sorry. Got confused. I though you weren't the submitter, for some
> strange reason. Anyway, I see this in the code:
>
>
>>>+ /* Handle array types */
>>>+ if (typname[0] == '_')
>>>+ {
>>>+ isarray = true;
>>>+ typname++;
>>>+ }
>
>
> Do we know that is always true? What is the issue that 7.0 needs this
> and newer released don't, and how are we sure this will not break some
> strange cases in post-7.0 releases?
It's not a problem, since that code path is only ever executed when
dumping a 7.0 backend. It's in the MyFormatType function in pg_dump.c
that is used whenever the backend doesn't have its own format_type function.
Chris
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Потеряев =?koi8-r?b?IOku5S4=?= | 2004-05-17 06:34:36 | PITR Phase 1 - partial backport to 7.3.4, 7.3.5 |
| Previous Message | Bruce Momjian | 2004-05-17 04:04:39 | Re: Bug in CVS pg_dump against 7.0.x |