Re: Bug in CVS pg_dump against 7.0.x

Christopher Kings-Lynne wrote:
> >>I submitted a fix for 7.5 dumping 7.0 previously and it was accepted :)
>
> That previous fix was for a different issue...
>
> > Oh, it for using a 7.5 dump on a 7.0 database? I didn't think that
> > would even work. :-)
>
> Yes, it works fine. We still support pg_dumping all 7.x databases.
>
> > Anyway, you say the fix is already in CVS so we are OK.
>
> *cry*
>
> No, it's _not_ in CVS - that's what my patch is for! My patch is
> against 7.5CVS!

Duh, sorry. Got confused. I though you weren't the submitter, for some
strange reason. Anyway, I see this in the code:

>>+ /* Handle array types */
>>+ if (typname[0] == '_')
>>+ {
>>+ isarray = true;
>>+ typname++;
>>+ }

Do we know that is always true? What is the issue that 7.0 needs this
and newer released don't, and how are we sure this will not break some
strange cases in post-7.0 releases?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073