Re: HS/SR and smart shutdown

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Josh Berkus <josh(at)agliodbs(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: HS/SR and smart shutdown
Date: 2010-01-30 03:54:30
Message-ID: 3f0b79eb1001291954j4a8df6e2nbc41fa74a261ad38@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jan 30, 2010 at 9:01 AM, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
> I don't think it's clear, or intuitive for users.  In SR, recovery is
> *never* done, so smart shutdown never completes (even if the master is
> shut down, when I tested it).

If you specify the trigger_file parameter in the recovery.conf, the presence
of the trigger file would complete recovery. So the existing smart shutdown
waits for it to be created. I agree that this behavior is somewhat confusing
for users.

> HOWEVER, I do believe this is an issue we could live with for 9.0 if
> it's going to lead to a whole lot of additional debugging of SR.  But if
> it's an easy fix, it'll avoid a lot of complaints on pgsql-general.

I think that the latter statement is right.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Oleg Bartunov 2010-01-30 06:12:16 rbtree test data
Previous Message Alex Hunsaker 2010-01-30 03:07:30 Re: Package namespace and Safe init cleanup for plperl [PATCH]