Re: Incorrect CHUNKHDRSZ in nodeAgg.c

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Incorrect CHUNKHDRSZ in nodeAgg.c
Date: 2025-01-08 20:50:10
Message-ID: 3d9b8f7609039c5775cc8272f09054faea794c66.camel@j-davis.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 2025-01-06 at 12:34 -0800, Jeff Davis wrote:
> If we separate out 4, we can use the Bump allocator for 2 & 3.

Attached POC patch, which reduces memory usage by ~15% for a simple
distinct query on an integer key. Performance is the same or perhaps a
hair faster.

It's not many lines of code, but the surrounding code might benefit
from some refactoring which would make it a bit simpler.

Regards,
Jeff Davis

Attachment Content-Type Size
v1-0001-HashAgg-use-Bump-context-for-hash-table-entries.patch text/x-patch 5.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-01-08 20:58:25 Re: improve DEBUG1 logging of parallel workers for CREATE INDEX?
Previous Message Guillaume Lelarge 2025-01-08 20:48:17 Re: improve DEBUG1 logging of parallel workers for CREATE INDEX?