Re: plperl version on the meson setup summary screen

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Zharkov Roman <r(dot)zharkov(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: plperl version on the meson setup summary screen
Date: 2024-11-27 14:50:57
Message-ID: 3d954f95-859b-46cd-a310-a9669113efb2@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2024-10-17 Th 10:02 PM, Zharkov Roman wrote:
> Hello,
>
> Would it be convinient to show the plperl version on the meson setup
> summary
> screen? Now it displays only 'YES' or 'NO'. This is the expected
> behavior of
> the meson build system and explains in its source code:
> https://github.com/mesonbuild/meson/blob/5f0bd8ff1e7fc43199d4b371fc4625f80baba810/mesonbuild/dependencies/base.py#L311C15-L311C27
>
> With the attached patch we can see the "perlversion" in the summary
> information table. But without a beautiful console colorize.
>

Yeah, the lack of version number has mildly annoyed me too, so let's fix
it. I haven't found the right secret sauce to make the version number
appear colorized, either. Maybe some meson guru can tell us how.

> Additionaly, we found out that "perlversion" gets from the perl
> "api_versionstring" config variable. When the configure script parses the
> "perl -v" output:
>
>> pgac_perl_version=`$PERL -v 2>/dev/null | sed -n 's/This is
>> perl.*v[a-...
>
> Is this behavior correct?

I think it's ok, it should give the same answer AFAIK. Using sed like
this to parse the output of 'perl -v' is somewhat hacky, so the meson
recipe is arguably an improvement.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2024-11-27 14:52:45 Re: Self contradictory examining on rel's baserestrictinfo
Previous Message Fujii Masao 2024-11-27 14:45:23 Re: Add reject_limit option to file_fdw