| From: | "Euler Taveira" <euler(at)eulerto(dot)com> |
|---|---|
| To: | "Alvaro Herrera" <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | "Tender Wang" <tndrwang(at)gmail(dot)com>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, tharakan(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org, "Heikki Linnakangas" <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: BUG #18866: Running pg_freespace() on views triggers an Abort |
| Date: | 2025-03-26 19:00:28 |
| Message-ID: | 3ce0c391-2abc-444d-9a49-5ed86dd6b504@app.fastmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Wed, Mar 26, 2025, at 2:33 PM, Álvaro Herrera wrote:
> On 2025-Mar-25, Euler Taveira wrote:
>
> > On Tue, Mar 25, 2025, at 10:18 PM, Tender Wang wrote:
> > > Thanks for the advice. Please see the attached patch.
> >
> > Your patch needs some adjustments. There is no need to include pg_class.h.
>
> I think including pg_class.h (which is where RELKIND_HAS_STORAGE() is
> defined and where errdetail_relkind_not_supported is declared) is better
> than including utils/rel.h, which brings in a whole bunch of additional
> stuff in addition to pg_class.h :-)
It doesn't work because of RelationGetRelationName() that is defined into
utils/rel.h.
--
Euler Taveira
EDB https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2025-03-26 19:06:08 | Re: BUG #18866: Running pg_freespace() on views triggers an Abort |
| Previous Message | Álvaro Herrera | 2025-03-26 17:33:42 | Re: BUG #18866: Running pg_freespace() on views triggers an Abort |