| From: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Euler Taveira <euler(at)eulerto(dot)com> |
| Cc: | Tender Wang <tndrwang(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, tharakan(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: BUG #18866: Running pg_freespace() on views triggers an Abort |
| Date: | 2025-03-26 17:33:42 |
| Message-ID: | 202503261733.mcrnkm6myu6y@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 2025-Mar-25, Euler Taveira wrote:
> On Tue, Mar 25, 2025, at 10:18 PM, Tender Wang wrote:
> > Thanks for the advice. Please see the attached patch.
>
> Your patch needs some adjustments. There is no need to include pg_class.h.
I think including pg_class.h (which is where RELKIND_HAS_STORAGE() is
defined and where errdetail_relkind_not_supported is declared) is better
than including utils/rel.h, which brings in a whole bunch of additional
stuff in addition to pg_class.h :-)
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end." (2nd Commandment for C programmers)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Euler Taveira | 2025-03-26 19:00:28 | Re: BUG #18866: Running pg_freespace() on views triggers an Abort |
| Previous Message | Euler Taveira | 2025-03-26 16:51:51 | Re: BUG #18866: Running pg_freespace() on views triggers an Abort |