| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, vladimirlesk(at)yandex-team(dot)ru, dsarafan(at)yandex-team(dot)ru |
| Subject: | Re: Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line |
| Date: | 2019-03-07 07:26:54 |
| Message-ID: | 3a16b540-0e4a-ceb3-4091-171a57600756@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/6/19 5:38 PM, Andrey Borodin wrote:
>> 20 февр. 2019 г., в 17:06, Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru> написал(а):
>
> The new patch is much smaller (less than 400 lines) and works as advertised.
> There's a typo "retreive" there.
>
> These lines look a little suspicious:
> char postgres_exec_path[MAXPGPATH],
> postgres_cmd[MAXPGPATH],
> cmd_output[MAX_RESTORE_COMMAND];
> Is it supposed to be any difference between MAXPGPATH and MAX_RESTORE_COMMAND?
>
> Besides this, patch looks fine to me.
This patch appears to need attention from the author so I have marked it
Waiting on Author.
Regards,
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-03-07 07:27:04 | Re: pg_basebackup against older server versions |
| Previous Message | Peter Geoghegan | 2019-03-07 07:23:15 | Re: Making all nbtree entries unique by having heap TIDs participate in comparisons |