From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | |
Cc: | Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCHES] Double Backslash example patch |
Date: | 2003-12-17 18:49:31 |
Message-ID: | 3FE0A53B.6020704@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
>Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>
>>I see that psql/mainloop.c contains this comment:
>> * FIXME: rewrite this whole thing with flex
>>Is now the time to do that?
>>
>>
>
>If you feel like giving it a shot, ain't nobody gonna stand in your way.
>MainLoop() is well past the level of unmaintainability IMHO (which is
>why I'd not tried to touch it in the original quick patch).
>
>I'm not totally convinced that flex can do the job, but in any case a
>ground-up redesign for legibility might be the only cure.
>
>
>
I will take a look - no guarantees though. I agree that flex might well
end up making things more obscure than less.
Keeping track of open quote operators to make sure we have proper
nesting and closing looks like it might be a bit messy, but doable.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Tilo Schwarz | 2003-12-17 19:56:38 | time interval behaviour seems odd |
Previous Message | Tom Lane | 2003-12-17 18:07:35 | Re: [PATCHES] Double Backslash example patch |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2003-12-17 23:16:27 | Re: restore error - language "plperlu" is not trusted |
Previous Message | Tom Lane | 2003-12-17 18:45:52 | Re: restore error - language "plperlu" is not trusted |