Re: [HACKERS] statement level trigger causes pltcl, plpython

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] statement level trigger causes pltcl, plpython
Date: 2003-08-04 17:11:06
Message-ID: 3F2E93AA.4090208@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Joe Conway <mail(at)joeconway(dot)com> writes:
>
>>Note that I also changed behavior in that when trigdata->tg_event
>>doesn't match anything known -- instead of pressing on with a value of
>>"UNKNOWN" it now throws an "elog(ERROR...". The previous behavior made
>>no sense to me, but you may not want to change existing behavior in this
>>way (even though it seems to me that it is a "should not happen" kind of
>>error).
>
> Seems reasonable to me. As a matter of style, the "unrecognized" elogs
> should print the offending tg_event value; otherwise the patch looks fine.
>
>>If this patch is acceptable, I'll make similar changes to plpython.
>
> Please do.
>

This patch includes pltcl and plpython, with the mentioned style issue
fixed. Both PLs pass their scripted tests and my simple statement level
trigger test.

Joe

Attachment Content-Type Size
pl-statement-trig-fix.1.patch text/plain 10.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2003-08-04 17:11:45 Re: Thread-safe configuration option appears to
Previous Message Joe Conway 2003-08-04 17:00:45 Re: problem with RH7.3 Pg7.3.4 binaries

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2003-08-04 17:38:20 Re: 7.4 COPY BINARY Format Change
Previous Message Lee Kindness 2003-08-04 16:44:27 Re: 7.4 COPY BINARY Format Change