From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Joe Conway <mail(at)joeconway(dot)com> |
Cc: | "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] statement level trigger causes pltcl, plpython SIGSEGV |
Date: | 2003-08-04 13:49:41 |
Message-ID: | 25054.1060004981@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Joe Conway <mail(at)joeconway(dot)com> writes:
> Note that I also changed behavior in that when trigdata->tg_event
> doesn't match anything known -- instead of pressing on with a value of
> "UNKNOWN" it now throws an "elog(ERROR...". The previous behavior made
> no sense to me, but you may not want to change existing behavior in this
> way (even though it seems to me that it is a "should not happen" kind of
> error).
Seems reasonable to me. As a matter of style, the "unrecognized" elogs
should print the offending tg_event value; otherwise the patch looks fine.
> If this patch is acceptable, I'll make similar changes to plpython.
Please do.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2003-08-04 13:53:04 | Re: Release changes |
Previous Message | Tom Lane | 2003-08-04 13:46:30 | Re: DROP TYPE/DROP DOMAIN |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2003-08-04 14:00:58 | Re: [pgsql-rus] Russian NLS update: pg_dump, libpq, |
Previous Message | Tom Lane | 2003-08-04 13:44:01 | Re: 7.4 COPY BINARY Format Change |