Re: [HACKERS] allowed user/db variables

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andreas Pflug <Andreas(dot)Pflug(at)web(dot)de>, Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Subject: Re: [HACKERS] allowed user/db variables
Date: 2003-07-19 04:23:46
Message-ID: 3F18C7D2.10509@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

I'm going to resend the patches that I have outstanding since it appears
some may have been lost. Here's the third of three.
===================================================

Tom Lane wrote:
> Joe Conway <mail(at)joeconway(dot)com> writes:
>>ISTM that "source" is worth knowing.
>
> Hm, possibly. Any other opinions?

This version has the seven fields I proposed, including "source". Here's
an example that shows why I think it's valuable:

regression=# \x
Expanded display is on.
regression=# select * from pg_settings where name = 'enable_seqscan';
-[ RECORD 1 ]-----------
name | enable_seqscan
setting | on
context | user
vartype | bool
source | default
min_val |
max_val |

regression=# update pg_settings set setting = 'off' where name =
'enable_seqscan';
-[ RECORD 1 ]---
set_config | off

regression=# select * from pg_settings where name = 'enable_seqscan';
-[ RECORD 1 ]-----------
name | enable_seqscan
setting | off
context | user
vartype | bool
source | session
min_val |
max_val |

regression=# alter user postgres set enable_seqscan to 'off';
ALTER USER

(log out and then back in again)

regression=# \x
Expanded display is on.
regression=# select * from pg_settings where name = 'enable_seqscan';
-[ RECORD 1 ]-----------
name | enable_seqscan
setting | off
context | user
vartype | bool
source | user
min_val |
max_val |

In the first case, enable_seqscan is set to its default value. After
setting it to off, it is obvious that the value has been changed for the
session only. In the third case, you can see that the value has been set
specifically for the user.

This version of the patch also includes documentation changes. Passes
all regression tests. Please apply.

Joe

Attachment Content-Type Size
pg_settings_expanded.2.patch text/plain 19.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2003-07-19 05:39:57 Re: Urgent: 10K or more connections
Previous Message Kris Jurka 2003-07-19 03:22:24 Re: Urgent: 10K or more connections

Browse pgsql-patches by date

  From Date Subject
Next Message Larry Rosenman 2003-07-19 16:58:26 Re: PG Patch (fwd) [OpenServer followup #1]
Previous Message Joe Conway 2003-07-19 04:19:03 Re: [NOVICE] connectby(... pos_of_sibling)