| From: | "David E(dot) Wheeler" <david(at)kineticode(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, David Fetter <david(at)fetter(dot)org>, Euler Taveira de Oliveira <euler(at)timbira(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PGXS: REGRESS_OPTS=--load-language=plpgsql |
| Date: | 2010-02-19 15:43:04 |
| Message-ID: | 3E0F82F0-CAB5-4273-8816-0D78DDF09066@kineticode.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Feb 19, 2010, at 5:36 AM, Alvaro Herrera wrote:
>> Because it's a lot easier for `pg_regress --load-language=plpgsql` to mean "ensure the language is installed" than it is for 3rd-party test suites to detect what version they're being installed against.
>
> Why doesn't the Makefile running the tests simply avoid adding
> --load-language when the version is higher than 9.0? Shouldn't be a
> hard test to write. We have $(MAJORVERSION) to help with this.
Usually PGXS loads after setting all the environment variables, though I suspect that it wouldn't have any side effects to set regress_opts afterward. Also, there is no MAJORVERSION in earlier versions, so module authors would have to work around that.
Basically though, you're asking all third party module authors who depend on plpgsql in their code and/or tests to modify their makefiles and release new versions to work around something that pg_regress could have fixed internally in 1-2 lines of code and be done with it.
Best,
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Oleg Bartunov | 2010-02-19 16:00:48 | Re: Merge join and index scan strangeness |
| Previous Message | Erik Rijkers | 2010-02-19 15:33:43 | Re: testing cvs HEAD - HS/SR - PANIC: cannot make new WAL entries during recovery |