Re: anonymous composite types for Table Functions (aka

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: anonymous composite types for Table Functions (aka
Date: 2002-08-05 02:10:20
Message-ID: 3D4DDE8C.7070903@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Okay. I have patches to fix the domain-type issues, and will commit
> as soon as I've finished testing 'em.

Thanks.

>
> I would suggest that either gram.y or someplace early in the analyzer
> should transpose the names from the coldeflist into the "user specified
> alias" structure. That should fix the alias naming issues. The other
> issues indicate that if a coldeflist is provided, you should check it
> against the function return type in all cases not only RECORD. In the
> non-RECORD cases it could be done in the parse analysis phase.

Actually, I was just looking at this and remembering that I wanted to
disallow a coldeflist for non-RECORD return types. Do you prefer to
allow it (but properly apply the alias and enforce the type)?

Joe

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Lockhart 2002-08-05 02:23:11 Re: Did someone break CVS?
Previous Message Tom Lane 2002-08-05 02:08:54 Re: Did someone break CVS?

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-08-05 02:58:47 Re: anonymous composite types for Table Functions (aka SRFs)
Previous Message Tom Lane 2002-08-05 02:05:21 Re: anonymous composite types for Table Functions (aka SRFs)