From: | Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | refcnt leak ? |
Date: | 2000-11-07 10:35:17 |
Message-ID: | 3A07DAE5.4C0FF4F2@tpf.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi
While examining recursive use of catalog cache,I found
a refcnt leak of relations.
After further investigation,I found that the following seems
to be the cause.
[ in EndAppend() in nodeAppend.c ]
appendstate->as_result_relation_info_list = NIL;
/*
* This next step is critical to prevent EndPlan() from trying to close
* an already-closed-and-deleted RelationInfo ---
es_result_relation_info
* is pointing at one of the nodes we just zapped above.
*/
estate->es_result_relation_info = NULL;
This seems to cause a refcnt leak when
appendstate->as_result_relation_info_list is NIL from the first
e.g. in the case INSERT INTO .. SELECT ...
Comments ?
BTW,doesn't EndAppend() neglect to call ExecCloseIndices()
for RelationInfos of appendstate->as_result_relation_info_list ?
Regards.
Hiroshi Inoue
From | Date | Subject | |
---|---|---|---|
Next Message | Pete Forman | 2000-11-07 10:54:32 | AW: v7.0.3 *pre-release* ... |
Previous Message | Zeugswetter Andreas SB | 2000-11-07 10:17:13 | Again please no // comments !!!!!!!! |