Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Álvaro Hernández Tortosa <aht(at)8kdata(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256
Date: 2018-01-04 22:12:41
Message-ID: 395.1515103961@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-jdbc

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 1/4/18 16:17, Tom Lane wrote:
>> dromedary is whinging about OBJ_find_sigid_algs, as well.

> Yeah, it seems like we might need to fine-tune this a bit more to make
> it work across all OpenSSL versions. I'm going to let the buildfarm
> take a run through the current code and see what other issues arise.

Well, it looks like the older machines don't like OBJ_find_sigid_algs,
and the newest machines don't like what you're trying to pass to it:

/home/andres/build/buildfarm-calliphoridae/HEAD/pgsql.build/../pgsql/src/backend/libpq/be-secure-openssl.c: In function ‘be_tls_get_certificate_hash’:
/home/andres/build/buildfarm-calliphoridae/HEAD/pgsql.build/../pgsql/src/backend/libpq/be-secure-openssl.c:1268:50: error: dereferencing pointer to incomplete type ‘X509 {aka struct x509_st}’
if (!OBJ_find_sigid_algs(OBJ_obj2nid(server_cert->sig_alg->algorithm),
^~

so this is looking mighty like a crashed and burned patch from here :-(

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2018-01-04 22:14:26 Re: pgsql: Add parallel-aware hash joins.
Previous Message Remi Colinet 2018-01-04 22:07:30 Re: [Patch v2] Make block and file size for WAL and relations defined at cluster creation

Browse pgsql-jdbc by date

  From Date Subject
Next Message Michael Paquier 2018-01-05 01:00:11 Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256
Previous Message Peter Eisentraut 2018-01-04 21:53:27 Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256