Re: Obsolete comment in ExecInsert()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Obsolete comment in ExecInsert()
Date: 2022-09-28 14:42:21
Message-ID: 3946130.1664376141@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> writes:
> I think the “or a tuple has come for a different relation than that
> for the accumulated tuples" part in the comment is a leftover from an
> earlier version of the patch [1]. As the code shows, we do not handle
> that case anymore, so I think we should remove that part from the
> comment. Attached is a patch for that.

+1, but what remains still seems awkwardly worded. How about something
like "When we've reached the desired batch size, perform the insertion"?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2022-09-28 14:46:08 Move backup-related code to xlogbackup.c/.h
Previous Message Melih Mutlu 2022-09-28 14:41:45 Re: Summary function for pg_buffercache