| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
| Cc: | Steven Niu <niushiji(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Not-terribly-safe checks for CRC intrinsic support |
| Date: | 2025-03-17 02:13:01 |
| Message-ID: | 3896540.1742177581@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"David G. Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> writes:
> On Sunday, March 16, 2025, Steven Niu <niushiji(at)gmail(dot)com> wrote:
>> +# is missing, we must link not just compile, and store the results in
>> global
> I’d probably add a comma before the “not” though. Or maybe: we must also
> link and store the results in global
A comma there wouldn't be wrong, but in context that would make for
an overabundance of commas. Or so it seems to me anyway.
> Doesn’t link imply compilation?
Yes.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2025-03-17 02:49:49 | Re: TOAST versus toast |
| Previous Message | David G. Johnston | 2025-03-17 02:01:49 | Re: Not-terribly-safe checks for CRC intrinsic support |