From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Refactor the sslfiles Makefile target for ease of use |
Date: | 2021-10-27 19:57:42 |
Message-ID: | 387192BC-26E5-4D9A-A2C1-3F9AB79B7FC2@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
> On 27 Oct 2021, at 16:37, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> On 26 Oct 2021, at 19:41, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
>> This fails during 'make clean' in a vpath build, because sslfiles.mk cannot be
>> found. Probably just needs
>
> It does in fact need that diff, but sslfiles.mk also needs to be taught about
> the current $(srcdir) to properly function under VPATH for "make sslfiles".
Discussing this off-list with Jacob, and dabbling some more with it, this needs
more thought. It's not clear what make sslfiles should do in a VPATH build,
and where, since the artefacts are both generated and distributed. I've pushed
the small fix to ensure "make clean" works as that's a much more common
usecase, to allow for time to discuss "make sslfiles" on -hackers.
--
Daniel Gustafsson https://vmware.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2021-10-27 20:10:40 | pgsql: Fix ordering of items in nbtree error message. |
Previous Message | Daniel Gustafsson | 2021-10-27 19:53:51 | pgsql: Fix VPATH builds for src/test/ssl targets |