From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Refactor the sslfiles Makefile target for ease of use |
Date: | 2021-10-27 20:53:32 |
Message-ID: | 20211027205332.dp22qru3n25g7kyn@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
i,
On 2021-10-27 21:57:42 +0200, Daniel Gustafsson wrote:
> > On 27 Oct 2021, at 16:37, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> >
> >> On 26 Oct 2021, at 19:41, Andres Freund <andres(at)anarazel(dot)de> wrote:
> >
> >> This fails during 'make clean' in a vpath build, because sslfiles.mk cannot be
> >> found. Probably just needs
> >
> > It does in fact need that diff, but sslfiles.mk also needs to be taught about
> > the current $(srcdir) to properly function under VPATH for "make sslfiles".
I think that may previously also not have worked. I mostly care about getting
make clean to work again...
> Discussing this off-list with Jacob, and dabbling some more with it, this needs
> more thought. It's not clear what make sslfiles should do in a VPATH build,
> and where, since the artefacts are both generated and distributed.
It's imo pretty clear that it'd need to put the files in the source directory.
> I've pushed the small fix to ensure "make clean" works as that's a much more
> common usecase, to allow for time to discuss "make sslfiles" on -hackers.
Cool!
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Davis | 2021-10-27 21:10:48 | pgsql: Grant memory views to pg_read_all_stats. |
Previous Message | Daniel Gustafsson | 2021-10-27 20:41:00 | pgsql: Fix typos in comments |