Re: Virtual generated columns

On 18.09.24 04:38, jian he wrote:
> On Mon, Sep 16, 2024 at 5:22 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>>
>> in v7.
>>
> seems I am confused with the version number.
>
> here, I attached another minor change in tests.
>
> make
> ERROR: invalid ON DELETE action for foreign key constraint containing
> generated column
> becomes
> ERROR: foreign key constraints on virtual generated columns are not supported

I think the existing behavior is fine. The first message is about
something that is invalid anyway. The second message is just that
something is not supported yet. If we end up implementing, then users
will get the first message.

> change contrib/pageinspect/sql/page.sql
> expand information on t_infomask, t_bits information.

added to v8 patch

> change RelationBuildLocalRelation
> make the transient TupleDesc->TupleConstr three bool flags more accurate.

I don't think we need that. At the time this is used, the generation
expressions are not added to the table yet. Note that stored generated
columns are not dealt with here either. If there is a bug, then we can
fix it, but if not, then I'd rather keep the code simpler.