Re: bugfix - plpgsql - statement counter is incremented 2x for FOR stmt

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: bugfix - plpgsql - statement counter is incremented 2x for FOR stmt
Date: 2021-02-02 19:36:19
Message-ID: 3787233.1612294579@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> When I fixed one plpgsql_check issue, I found another plpgsql issue. Now we
> have field nstatements that hold a number of plpgsql statements in
> function. Unfortunately I made an error when I wrote this functionality and
> for FOR statements, this counter is incremented 2x. Higher number than a
> real number is better than a lesser number, but it can be a source of
> problems too (inside plpgsql_check I iterate over 0 .. nstatements stmtid,
> and due this bug I had a problem with missing statements).

> Attached patch is pretty simple:

Right, done.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2021-02-02 19:54:47 Re: bugfix - plpgsql - statement counter is incremented 2x for FOR stmt
Previous Message Tom Lane 2021-02-02 18:13:42 Re: memory leak in auto_explain