Re: [HACKERS] New TODO item

From: Thomas Lockhart <lockhart(at)alumni(dot)caltech(dot)edu>
To: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "PostgreSQL-development"(at)candle(dot)pha(dot)pa(dot)us, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] New TODO item
Date: 1999-06-18 02:31:02
Message-ID: 3769AF66.B6F02756@alumni.caltech.edu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> > Looks to me like the parser is failing to reject this query as malformed.
> > transformIdent() is willing to take either a column name or a relation
> > name (why?), and no one upstream is rejecting the relation-name case.
> There is some reason for this that I think Thomas can tell us.

Moi? Why drag me into this? ;)

I'm not recalling why we would want to handle bare relation names in
an expression, but it does seem that a flag is being set in
transformIdent() which one could test later to verify that you have a
column. afaik this code predates my contributions, so I don't have
much insight into it. (It is true that there are a few extensions to
the SQL syntax which are holdovers from the PostQuel language, which
explains a few odd features in the parser.)

Would you prefer that we do nothing until I have a chance to research
this some more, or is someone going to dive in?

- Thomas

--
Thomas Lockhart lockhart(at)alumni(dot)caltech(dot)edu
South Pasadena, California

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 1999-06-18 02:32:45 Re: [HACKERS] This is weird
Previous Message Bruce Momjian 1999-06-18 02:30:31 Re: [HACKERS] tables > 1 gig