| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
| Cc: | koichi(dot)dbms(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18735: Specific multibyte character in psql file path command parameter for Windows |
| Date: | 2024-12-08 22:55:12 |
| Message-ID: | 3768611.1733698512@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Tatsuo Ishii <ishii(at)postgresql(dot)org> writes:
>> Another way, given that we only really need this to work for
>> SJIS, is to hard-wire the logic into path.c --- it's not like
>> pg_sjis_mblen is either long or likely to change. That's
>> ugly but would be a lot less invasive and safer to back-patch.
>> I'm leaning a bit to the second way, mainly because of the
>> extern-relocation annoyance.
> +1. I believe the logic of detecting byte length in Shift-JIS will not
> be changed.
OK. I know I said I wasn't going to write this, but here's a draft
patch that assumes we need only touch psql and can rely on its idea
of client_encoding.
I'm not in a position to test this.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| v1-encoding-safe-canonicalize_path.patch | text/x-diff | 7.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2024-12-09 01:28:26 | Re: [Bug] Heap Use After Free in Window Aggregate Execution |
| Previous Message | PG Bug reporting form | 2024-12-08 12:00:01 | BUG #18741: Detaching a partition referencing a partitioned table fails with a trigger-related error |