Re: pgsql: Fix 007_sync_rep.pl to notice failures in ALTER SYSTEM SET.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix 007_sync_rep.pl to notice failures in ALTER SYSTEM SET.
Date: 2019-08-28 03:38:28
Message-ID: 3629.1566963508@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Mon, Aug 26, 2019 at 09:03:08PM +0000, Tom Lane wrote:
>> Fix 007_sync_rep.pl to notice failures in ALTER SYSTEM SET.

> Just for the note. I think that this needs a closer lookup and I am
> afraid that there are more issues like this one.

Yeah, it might be a good idea to make a sweep to see what other tests
should be using safe_psql.

Or, more radically, we could think about redefining PostgresNode::psql
to complain about errors, and you have to use something else if you
want it not to?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-08-28 06:39:13 Re: pgsql: Fix 007_sync_rep.pl to notice failures in ALTER SYSTEM SET.
Previous Message Michael Paquier 2019-08-28 03:29:23 pgsql: Improve coverage of utils/float.h