Re: pgsql: Fix 007_sync_rep.pl to notice failures in ALTER SYSTEM SET.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix 007_sync_rep.pl to notice failures in ALTER SYSTEM SET.
Date: 2019-08-28 06:39:13
Message-ID: 20190828063440.GI1965@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Aug 27, 2019 at 11:38:28PM -0400, Tom Lane wrote:
> Yeah, it might be a good idea to make a sweep to see what other tests
> should be using safe_psql.

I found more of these while browsing all the tests, so I am just going
to start a new thread with a patch.

> Or, more radically, we could think about redefining PostgresNode::psql
> to complain about errors, and you have to use something else if you
> want it not to?

Not sure about redesigning that as it has been around for a couple of
years now, and that would mean perhaps a third wrapper on top of
PostgresNode::psql.
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2019-08-28 08:44:03 pgsql: Avoid catalog lookups in RelationAllowsEarlyPruning().
Previous Message Tom Lane 2019-08-28 03:38:28 Re: pgsql: Fix 007_sync_rep.pl to notice failures in ALTER SYSTEM SET.