| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Bartosz Chroł <bartosz(dot)chrol(at)handen(dot)pl>, "pgsql-general(at)postgresql(dot)org" <pgsql-general(at)postgresql(dot)org> |
| Subject: | Re: pg_dumpall with flag --no-role-passwords omits roles comments as well |
| Date: | 2024-03-21 23:23:15 |
| Message-ID: | 357D8E79-7B75-4166-98C0-46CA9D365F5F@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general |
> On 21 Mar 2024, at 14:27, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2024-Mar-21, Daniel Gustafsson wrote:
>
>> On 21 Mar 2024, at 13:28, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>>
>>> I very much doubt that they realized that comments were going to be
>>> omitted. But clearly it's just a mistake, and easily fixed.
>>
>> It sure looks like a search/replace kind of bug. I had just typed up the exact
>> same patch with the addition of a comment on why pg_authid is used and was
>> about to hit send when your email came =) Are you committing it or do you want
>> me to take care of it?
>
> Hah :-) Please do.
Done, backpatched all the way since it's been broken since 2017.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-03-22 00:51:39 | Re: Slow GRANT ROLE on PostgreSQL 16 with thousands of ROLEs |
| Previous Message | Nathan Bossart | 2024-03-21 20:40:12 | Re: Slow GRANT ROLE on PostgreSQL 16 with thousands of ROLEs |