| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Bartosz Chroł <bartosz(dot)chrol(at)handen(dot)pl>, "pgsql-general(at)postgresql(dot)org" <pgsql-general(at)postgresql(dot)org> |
| Subject: | Re: pg_dumpall with flag --no-role-passwords omits roles comments as well |
| Date: | 2024-03-21 13:27:30 |
| Message-ID: | 202403211327.3mwhawgoeqp3@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general |
On 2024-Mar-21, Daniel Gustafsson wrote:
> On 21 Mar 2024, at 13:28, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> > I very much doubt that they realized that comments were going to be
> > omitted. But clearly it's just a mistake, and easily fixed.
>
> It sure looks like a search/replace kind of bug. I had just typed up the exact
> same patch with the addition of a comment on why pg_authid is used and was
> about to hit send when your email came =) Are you committing it or do you want
> me to take care of it?
Hah :-) Please do.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Here's a general engineering tip: if the non-fun part is too complex for you
to figure out, that might indicate the fun part is too ambitious." (John Naylor)
https://postgr.es/m/CAFBsxsG4OWHBbSDM%3DsSeXrQGOtkPiOEOuME4yD7Ce41NtaAD9g%40mail.gmail.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | gparc | 2024-03-21 14:54:57 | Re: Not able to purge partition |
| Previous Message | Laurenz Albe | 2024-03-21 12:48:19 | Re: Not able to purge partition |