Re: unused_oids script is broken with bsd sed

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: unused_oids script is broken with bsd sed
Date: 2018-04-25 11:54:31
Message-ID: 34a54c54-9132-1254-2bc3-d3489fb79728@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 04/25/2018 06:22 AM, Stas Kelvich wrote:
> Hi.
>
> BSD sed in macOS doesn't understand word boundary operator "\b". So after
> 372728b0d49 unused_oids doesn’t match all oids in new *.dat files marking
> all of them as unused.
>
> It is possible to write more portable regexps, e.g. change "\b" to
> something like "^.*{*.*", but it seems easier for feature use to just
> rewrite unused_oids in perl to match duplicate_oids. Also add in-place
> complain about duplicates instead of running uniq through oids array.
>

+many for rewriting in perl. Do you want to have a go at that? If not I
will.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2018-04-25 12:09:02 Re: Porting PG Extension from UNIX to Windows
Previous Message Andrew Gierth 2018-04-25 11:50:50 Re: lazy detoasting