Re: allow to \dtS+ pg_toast.*

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: allow to \dtS+ pg_toast.*
Date: 2021-01-05 23:46:01
Message-ID: 3454491.1609890361@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> writes:
> On Fri, 2020-12-18 at 11:33 -0600, Justin Pryzby wrote:
>>>> This makes toast tables a bit less special and easier to inspect.

Pushed, except for

>>> Another thing that is missing is tab completion for
>>> regression=# \dtS pg_toast.pg_
>>> This should work just like for \d and \dS.

>> I agree that it's nice to complete the schema name, but I'm still not convinced
>> this part should be included.

> Again a judgement call. I am happy with the way the latest patch does it.

I remain pretty much against including toast tables in tab completion,
so I left out that part.

>> I considered whether "toast table" should be capitalized (as it is for "\d")
>> but I think it should stay lowercase.

> Then you should also change the way \d does it (upper case).
> I think we should be consistent.

I think capitalized TOAST is correct, because it's an acronym.
I also agree that consistency with what \d shows is important,
and I have no desire to change \d's longstanding output.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2021-01-05 23:50:20 Re: allow to \dtS+ pg_toast.*
Previous Message Craig Ringer 2021-01-05 23:30:37 Re: [PATCH] Runtime control of CLOBBER_CACHE_ALWAYS