| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove distprep |
| Date: | 2023-07-14 09:48:26 |
| Message-ID: | 3277117.1689328106@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> Ah, there was a reason. The headerscheck and cpluspluscheck targets
> need jsonpath_gram.h to be built first. Which previously happened
> indirectly somehow? I have fixed this in the new patch version. I also
> fixed the issue that Álvaro reported nearby.
Have we yet run this concept past the packagers list? I'm still
wondering if they will raise any objection to getting rid of all
the prebuilt files.
Also, I personally don't like the fact that you have removed the
distinction between distclean and maintainer-clean. I use
distclean-and-reconfigure quite a lot to avoid having to rebuild
bison/flex outputs. This patch seems to have destroyed that
workflow optimization in return for not much.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2023-07-14 10:28:59 | Re: logical decoding and replication of sequences, take 2 |
| Previous Message | Melih Mutlu | 2023-07-14 09:36:49 | Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication |