| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, wliang(at)stu(dot)xidian(dot)edu(dot)cn, pgsql-bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Report a potential memory leak in setup_config() |
| Date: | 2022-02-16 02:38:11 |
| Message-ID: | 3244453.1644979091@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
I wrote:
> Yeah, I read that. I think making the backend read these files directly
> makes a ton of sense, so I'm no longer very excited about improving the
> performance or memory consumption of the replace_token stuff.
Actually, wait a second. I grant your point about postgres.bki, but
a whole lot of the replace_token calls in initdb are messing with
the configuration files, which (a) is something I don't see changing,
and (b) pretty much none of that could be pushed back to build time.
So even though the config files are a lot smaller than postgres.bki,
maybe there's still a point in polishing replace_token a bit.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-02-16 04:10:49 | Re: Report a potential memory leak in setup_config() |
| Previous Message | Tom Lane | 2022-02-16 02:25:58 | Re: Report a potential memory leak in setup_config() |