Re: pgsql: Prevent instability in contrib/pageinspect's regression test.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Prevent instability in contrib/pageinspect's regression test.
Date: 2022-11-21 18:08:58
Message-ID: 3219281.1669054138@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Nov 21, 2022 at 12:35 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Hmm, so the problem is:
>>
>> SELECT octet_length(get_raw_page('test1', 'main', 0)) AS main_0;
>> ERROR: cannot access temporary tables during a parallel operation
>>
>> Why in the world is get_raw_page() marked as parallel safe?
>> It clearly isn't, given this restriction.

> I suspect that restriction was overlooked when evaluating the marking
> of this function.

So it would seem. PARALLEL RESTRICTED should work, though.

I'll check to see if any sibling functions have the same issue,
and push a patch to adjust them.

Presumably the parallel labeling has to be fixed as far back as
it's marked that way (didn't look). Maybe we should push the
test change further back too, just to exercise this.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-11-21 19:12:49 Re: pgsql: Prevent instability in contrib/pageinspect's regression test.
Previous Message Robert Haas 2022-11-21 17:52:01 Re: pgsql: Prevent instability in contrib/pageinspect's regression test.

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2022-11-21 18:11:13 Re: Catalog_xmin is not advanced when a logical slot is lost
Previous Message Robert Haas 2022-11-21 17:52:01 Re: pgsql: Prevent instability in contrib/pageinspect's regression test.