| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, robertmhaas(at)gmail(dot)com, ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com, andres(at)anarazel(dot)de, tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com, bruce(at)momjian(dot)us, pgsql-hackers(at)lists(dot)postgresql(dot)org, michael(dot)paquier(at)gmail(dot)com, david(at)pgmasters(dot)net, craig(at)2ndquadrant(dot)com |
| Subject: | Re: Protect syscache from bloating with negative cache entries |
| Date: | 2020-01-21 19:17:53 |
| Message-ID: | 31568.1579634273@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> On 2020-Jan-21, Tomas Vondra wrote:
>> Not sure about the appveyor build (it seems to be about jsonb_set_lax),
FWIW, I think I fixed jsonb_set_lax yesterday, so that problem should
be gone the next time the cfbot tries this.
>> but on travis it fails like this:
>> catcache.c:820:1: error: no previous prototype for ‘CatalogCacheFlushCatalog2’ [-Werror=missing-prototypes]
> Hmm ... travis is running -Werror? That seems overly strict. I think
> we shouldn't punt a patch because of that.
Why not? We're not going to allow pushing a patch that throws warnings
on common compilers. Or if that does happen, some committer is going
to have to spend time cleaning it up. Better to clean it up sooner.
(There is, btw, at least one buildfarm animal using -Werror.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2020-01-21 20:49:33 | Re: error context for vacuum to include block number |
| Previous Message | Tom Lane | 2020-01-21 19:13:22 | Re: Ltree syntax improvement |