| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, robertmhaas(at)gmail(dot)com, ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com, andres(at)anarazel(dot)de, tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com, bruce(at)momjian(dot)us, pgsql-hackers(at)lists(dot)postgresql(dot)org, michael(dot)paquier(at)gmail(dot)com, david(at)pgmasters(dot)net, craig(at)2ndquadrant(dot)com |
| Subject: | Re: Protect syscache from bloating with negative cache entries |
| Date: | 2020-01-22 05:03:41 |
| Message-ID: | 20200122050341.GD174860@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 21, 2020 at 02:17:53PM -0500, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>> Hmm ... travis is running -Werror? That seems overly strict. I think
>> we shouldn't punt a patch because of that.
>
> Why not? We're not going to allow pushing a patch that throws warnings
> on common compilers. Or if that does happen, some committer is going
> to have to spend time cleaning it up. Better to clean it up sooner.
>
> (There is, btw, at least one buildfarm animal using -Werror.)
I agree that it is good to have in Mr Robot. More early detection
means less follow-up cleanup.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-01-22 05:09:39 | Re: We're getting close to the end of 2020-01 CF |
| Previous Message | Michael Paquier | 2020-01-22 05:01:51 | Re: Add MAIN_RELATION_CLEANUP and SECONDARY_RELATION_CLEANUP options to VACUUM |