Re: pgsql: Implement pipeline mode in libpq

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Implement pipeline mode in libpq

So jacana and fairywren are unhappy about this, and the failure reports
are totally uninformative:

Mar 15 21:14:33 cd /home/pgrunner/bf/root/HEAD/pgsql.build/../pgsql/src/test/modules/libpq_pipeline && TESTDIR='/home/pgrunner/bf/root/HEAD/pgsql.build/src/test/modules/libpq_pipeline' PATH="/home/pgrunner/bf/root/HEAD/pgsql.build/tmp_install/home/pgrunner/bf/root/HEAD/inst/bin:$PATH" LD_LIBRARY_PATH="/home/pgrunner/bf/root/HEAD/pgsql.build/tmp_install/home/pgrunner/bf/root/HEAD/inst/lib:$LD_LIBRARY_PATH" PGPORT='66678' PG_REGRESS='/home/pgrunner/bf/root/HEAD/pgsql.build/src/test/modules/libpq_pipeline/../../../../src/test/regress/pg_regress' REGRESS_SHLIB='/home/pgrunner/bf/root/HEAD/pgsql.build/src/test/regress/regress.dll' /bin/prove -I /home/pgrunner/bf/root/HEAD/pgsql.build/../pgsql/src/test/perl/ -I /home/pgrunner/bf/root/HEAD/pgsql.build/../pgsql/src/test/modules/libpq_pipeline --timer t/*.pl
Mar 15 21:14:38 t/001_libpq_pipeline....
Mar 15 21:14:38 # Failed test 'libpq_pipeline '
Mar 15 21:14:38 # at t/001_libpq_pipeline.pl line 23.
Mar 15 21:14:38
Mar 15 21:14:38 # Failed test 'libpq_pipeline '
Mar 15 21:14:38 # at t/001_libpq_pipeline.pl line 23.
Mar 15 21:14:38
Mar 15 21:14:38 # Failed test 'libpq_pipeline '
Mar 15 21:14:38 # at t/001_libpq_pipeline.pl line 23.
Mar 15 21:14:40
Mar 15 21:14:40 # Failed test 'libpq_pipeline '
Mar 15 21:14:40 # at t/001_libpq_pipeline.pl line 23.
Mar 15 21:14:40
Mar 15 21:14:40 # Failed test 'libpq_pipeline '
Mar 15 21:14:40 # at t/001_libpq_pipeline.pl line 23.
Mar 15 21:14:40
Mar 15 21:14:40 # Failed test 'libpq_pipeline '
Mar 15 21:14:40 # at t/001_libpq_pipeline.pl line 23.
Mar 15 21:14:40
Mar 15 21:14:40 # Failed test 'libpq_pipeline '
Mar 15 21:14:40 # at t/001_libpq_pipeline.pl line 23.
Mar 15 21:14:41 # Looks like you planned 8 tests but ran 15.
Mar 15 21:14:41 # Looks like you failed 7 tests of 15 run.
Mar 15 21:14:41 dubious
Mar 15 21:14:41 Test returned status 7 (wstat 1792, 0x700)
Mar 15 21:14:41 DIED. FAILED tests 2, 4, 6, 8-15
Mar 15 21:14:41 Failed 11/8 tests, -37.50% okay
Mar 15 21:14:41 Failed Test Stat Wstat Total Fail Failed List of Failed
Mar 15 21:14:41 -------------------------------------------------------------------------------
Mar 15 21:14:41 t/001_libpq_pipeline.pl 7 1792 8 14 175.00% 2 4 6 8-15
Mar 15 21:14:41 Failed 1/1 test scripts, 0.00% okay. 0/8 subtests failed, 100.00% okay.
Mar 15 21:14:41 make: *** [check] Error 7

I suspect that the "tests" output is including \r\n newlines
and the "split" operation is not handling that right.

regards, tom lane