| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Implement pipeline mode in libpq |
| Date: | 2021-03-16 14:36:06 |
| Message-ID: | 20210316143606.GA10815@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 2021-Mar-15, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > Implement pipeline mode in libpq
>
> So jacana and fairywren are unhappy about this, and the failure reports
> are totally uninformative:
Yeah. This is the main clue:
> Mar 15 21:14:41 # Looks like you planned 8 tests but ran 15.
> Mar 15 21:14:41 # Looks like you failed 7 tests of 15 run.
We called the program seven additional times with empty string, so the
split is emitting extra results that are empty strings.
> I suspect that the "tests" output is including \r\n newlines
> and the "split" operation is not handling that right.
That seems the right guess. We already use split(/\s+/) in other
scripts, particularly the Windows build ones, so that seems the correct
fix.
Pushed that fix.
--
Álvaro Herrera Valdivia, Chile
"I dream about dreams about dreams", sang the nightingale
under the pale moon (Sandman)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-03-16 15:16:51 | pgsql: Improve logging of bad parameter values in BIND messages. |
| Previous Message | Alvaro Herrera | 2021-03-16 14:32:42 | pgsql: (Blind) fix Perl splitting of strings at newlines |