Re: ISN extension - wrong volatility level for isn_weak() function

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Viktor Holmberg <v(at)viktorh(dot)net>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: ISN extension - wrong volatility level for isn_weak() function
Date: 2025-03-14 15:13:49
Message-ID: 3074065.1741965229@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Viktor Holmberg <v(at)viktorh(dot)net> writes:
> I haven’t checked the source code, but yes the isn_weak feature has some footgun potential. As it doesn’t respect transactions, but rather sets a flag on session level, it’s easy for the “isn weakness” to leak out into a connection pool.

Yeah, really that ought to be a GUC I should think. There isn't
anything well-designed about it ...

I found some prior discussion here:

https://www.postgresql.org/message-id/flat/C12AE0A2A752416C79F3EE81%40teje

but we don't seem to have pulled the trigger on changing anything.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Viktor Holmberg 2025-03-14 16:08:36 Re: ISN extension - wrong volatility level for isn_weak() function
Previous Message Tom Lane 2025-03-14 14:32:04 Re: BUG #18850: REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison