Re: BUG #18850: REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pm91(dot)arapov(at)gmail(dot)com
Cc: pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #18850: REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison
Date: 2025-03-14 14:32:04
Message-ID: 3055986.1741962724@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

PG Bug reporting form <noreply(at)postgresql(dot)org> writes:
> REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison

Let's see, in #18848 and #18849 you were complaining about
non-robust code, but here you want to remove robustness?
I think it's fine as-is. (The back story here is that we
used to support postfix operators, so the earlier error
for !OidIsValid(typeId2) postdates this bit. While I don't
think that support is ever coming back, I'm disinclined to
remove a couple of lines that would be important for it.)

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2025-03-14 15:13:49 Re: ISN extension - wrong volatility level for isn_weak() function
Previous Message Viktor Holmberg 2025-03-14 14:28:01 Re: ISN extension - wrong volatility level for isn_weak() function