Re: Minimal logical decoding on standbys

Hi,

On 4/7/23 8:27 PM, Drouvot, Bertrand wrote:
> Hi,
>

>> I think some of the patches might have more reviewers than really applicable,
>> and might also miss some. I'd appreciate if you could go over that...
>>
>
> Sure, will do in a couple of hours.
>

That looks good to me, just few remarks:

0005 is missing author/reviewer, I'd propose:

Author: "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>
Author: Andres Freund <andres(at)anarazel(dot)de>
Reviewed-by: Andres Freund <andres(at)anarazel(dot)de>
Reviewed-by: Robert Haas <robertmhaas(at)gmail(dot)com>
Reviewed-by: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Discussion: https://postgr.es/m/20230407075009.igg7be27ha2htkbt@awork3.anarazel.de

0006, I'd propose:

Author: "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>
Reviewed-By: Jeff Davis <pgsql(at)j-davis(dot)com>
Reviewed-By: Robert Haas <robertmhaas(at)gmail(dot)com>
Reviewed-by: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Reviewed-by: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>

0007, I'd propose:

Author: "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>
Author: Andres Freund <andres(at)anarazel(dot)de>
Author: Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> (in an older version)
Reviewed-by: FabrÌzio de Royes Mello <fabriziomello(at)gmail(dot)com>
Reviewed-by: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Reviewed-By: Robert Haas <robertmhaas(at)gmail(dot)com>

0009, I'd propose:

Author: "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>
Author: Andres Freund <andres(at)anarazel(dot)de>
Author: Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> (in an older version)
Reviewed-by: FabrÌzio de Royes Mello <fabriziomello(at)gmail(dot)com>
Reviewed-by: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Reviewed-By: Robert Haas <robertmhaas(at)gmail(dot)com>

It's hard (given the amount of emails that have been send during all this time),
but I do hope it's correct and that nobody is missing.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com